rusackas commented on code in PR #32867:
URL: https://github.com/apache/superset/pull/32867#discussion_r2033724919
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.jsx:
##########
@@ -29,6 +29,28 @@ import {
import { D3_FORMAT_OPTIONS, sharedControls } from
'@superset-ui/chart-controls';
import { columnChoices, PRIMARY_COLOR } from './controls';
+let deckgl_tiles;
+
+export const DEFAULT_DECKGL_TILES = [
+ ['mapbox://styles/mapbox/streets-v9', 'Streets'],
+ ['mapbox://styles/mapbox/dark-v9', 'Dark'],
+ ['mapbox://styles/mapbox/light-v9', 'Light'],
+ ['mapbox://styles/mapbox/satellite-streets-v9', 'Satellite Streets'],
+ ['mapbox://styles/mapbox/satellite-v9', 'Satellite'],
+ ['mapbox://styles/mapbox/outdoors-v9', 'Outdoors'],
Review Comment:
Hmm... I guess what we want to avoid here is any breaking change. Therefore,
we can't shift _existing_ charts to OSM (that's breaking) but we could set the
default for NEW charts to OSM, and leave MapBox enabled as an option. I'd also
be open to converting the built-in Superset examples to use OSM as well, so
things don't look broken when people first install Superset.
Maybe there's enough complexity to warrant a SIP. With that kind of
consensus, we would have an idea of the to-do list, and also could get
consensus to migrate away from MapBox to OSM if you (and others) think that's a
viable option. I'm largely in favor of sensible defaults and configurable
options, so long as we don't cause breaking changes, and provide migrations
where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
