fardin-developer commented on code in PR #33013:
URL: https://github.com/apache/superset/pull/33013#discussion_r2034816899
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberPeriodOverPeriod/utils.ts:
##########
@@ -16,10 +16,20 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { headerFontSize, subheaderFontSize } from '../sharedControls';
+import {
+ headerFontSize,
+ subheaderFontSize,
+ metricNameFontSize,
+} from '../sharedControls';
const headerFontSizes = [16, 20, 30, 48, 60];
const comparisonFontSizes = [16, 20, 26, 32, 40];
+const metricNameFontSizes = [12, 16, 20, 24, 28];
Review Comment:
Yes, the header font size is used for displaying the big number. I’ve
unified the font sizes for both the metric name and subheader (comparison) into
a single array:
const sharedFontSizes = [16, 20, 26, 32, 40];
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
