fardin-developer commented on code in PR #33013:
URL: https://github.com/apache/superset/pull/33013#discussion_r2034892728
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -293,6 +327,11 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
<div className={className}>
<div className="text-container" style={{ height: allTextHeight }}>
{this.renderFallbackWarning()}
+ {this.renderMetricName(
+ Math.ceil(
Review Comment:
Yup, I DRY’d it into a renderWithFontSize(rendererFn, fontSize) helper
method that calculates the height based on the font size and optional
trendline, and renders the desired content using the passed function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
