hxtmdev opened a new pull request, #33108: URL: https://github.com/apache/superset/pull/33108
- if thumbnail is COMPUTING then 202 without creating a new task - if thumbnail is ERROR (or missing for some other reason) then 404 <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Currently the thumbnail code 1. creates a new task even if it is already COMPUTING (ignored during task execution though), and 2. does not handle a missing image in cache (resulting in HTTP 500), for example in ERROR state This mitigates both. ### TESTING INSTRUCTIONS 1. make it so that screenshots take a long time, for example with an empty dashboard without #33107 and Playwright, request thumbnails a few times, observe log messages in worker about skipping those new tasks 2. misconfigure thumbnails so they ERROR out, observe 500 when requesting the result ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
