mistercrunch commented on code in PR #33108:
URL: https://github.com/apache/superset/pull/33108#discussion_r2042773346
##########
superset/dashboards/api.py:
##########
@@ -1307,6 +1308,11 @@ def thumbnail(self, pk: int, digest: str, **kwargs: Any)
-> WerkzeugResponse:
dashboard_id=dashboard.id,
force=False,
)
+
+ if (
+ cache_payload.should_trigger_task()
Review Comment:
looks like `should_trigger_task` is used in 4 places in the codebase, seems
to be worth looking into those 3 other calls and seeing if logic should apply
there, but from my perspective seems we should never trigger a task if it's in
computing state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
