kgabryje opened a new pull request, #33126: URL: https://github.com/apache/superset/pull/33126
### SUMMARY In table chart, when time comparison is enabled, we generated some broken column configs. 1. Due to faulty logic, we generated time comparison variants for every numeric column instead of only for metrics 2. We didn't render the "General" tab for the "Main" time comparison column This PR fixes both issues ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/user-attachments/assets/02d856f1-a9b6-4461-b1cc-58c746946db1 After: https://github.com/user-attachments/assets/1286e128-19d9-4829-95ba-d8baf29cb098 ### TESTING INSTRUCTIONS 1. Create a table chart with time comparison 2. Add some numeric columns and metrics 3. Verify that you can customize all 4 time comparison column names for each metric and that there are no redundant, not working column config items ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
