eschutho commented on code in PR #33196:
URL: https://github.com/apache/superset/pull/33196#discussion_r2053031763
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -188,6 +188,47 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
);
}
+ renderSubheader(maxHeight: number) {
+ const { bigNumber, subheader, width, bigNumberFallback } = this.props;
+ let fontSize = 0;
+
+ const NO_DATA_OR_HASNT_LANDED = t(
+ 'No data after filtering or data is NULL for the latest time record',
+ );
+ const NO_DATA = t(
+ 'Try applying different filters or ensuring your datasource has data',
+ );
+ let text = subheader;
+ if (bigNumber === null) {
+ text = bigNumberFallback ? NO_DATA : NO_DATA_OR_HASNT_LANDED;
Review Comment:
I don't believe so. I mapped that subhead to the subtitle in transformProps,
but let's test it out to be doubly sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
