LevisNgigi commented on code in PR #33196:
URL: https://github.com/apache/superset/pull/33196#discussion_r2055422222
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -188,19 +188,21 @@ class BigNumberVis extends
PureComponent<BigNumberVizProps> {
);
}
- renderSubtitle(maxHeight: number) {
- const { subtitle, width } = this.props;
+ rendermetricComparisonSummary(maxHeight: number) {
+ const { subheader, width } = this.props;
let fontSize = 0;
- if (subtitle) {
+ const text = subheader;
+
+ if (text) {
const container = this.createTemporaryContainer();
document.body.append(container);
try {
fontSize = computeMaxFontSize({
- text: subtitle,
+ text,
maxWidth: width * 0.9,
maxHeight,
- className: 'subtitle-line',
+ className: 'subheader-line',
Review Comment:
I restored the classname to how it was originally so that it does not break
any css customizations that users will have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
