michael-s-molina commented on PR #33204: URL: https://github.com/apache/superset/pull/33204#issuecomment-2838511130
Thanks for the PR @Abhishek-kumar-samsung. - The menu with input is not a common pattern used in Superset. For consistency, a Select would be more appropriate as @rusackas mentioned. - The max limit is calculated from [SQL_MAX_ROW](https://github.com/apache/superset/blob/c029b532d47d6a611535e6a6c846c959a4fbd707/superset/config.py#L970) and we can't allow that limit to be exceeded. This means that the Select would need to reject inputs that go beyond `SQL_MAX_ROW` or have negative values. - I'm not sure about the usefulness of this feature given that you can simply apply a `LIMIT` to the query which should be something users of SQL Lab will know. Keep in mind that Superset displays a warning when the values are limited by the query. <img width="366" alt="Screenshot 2025-04-29 at 08 46 26" src="https://github.com/user-attachments/assets/ca12e5ac-0193-49be-9032-3c9e75768313"; /> <br><br> Maybe @justinpark @kasiazjc @rusackas have some thoughts about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
