korbit-ai[bot] commented on code in PR #33296:
URL: https://github.com/apache/superset/pull/33296#discussion_r2068217443
##########
superset/jinja_context.py:
##########
@@ -378,7 +378,15 @@ def get_filters(self, column: str, remove_filter: bool =
False) -> list[Filter]:
flt.get("expressionType") == "SIMPLE"
and flt.get("clause") == "WHERE"
and flt.get("subject") == column
- and val
+ and (
+ val
+ or
+ # IS_NULL and IS_NOT_NULL operators do not have a value
+ op in (
+ FilterOperator.IS_NULL.value,
+ FilterOperator.IS_NOT_NULL.value,
+ )
+ )
Review Comment:
Makes sense. The current format does provide clear logical grouping. Let's
keep it as is unless senior contributors indicate otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
