Prokos commented on code in PR #33296:
URL: https://github.com/apache/superset/pull/33296#discussion_r2126009270
##########
tests/unit_tests/jinja_context_test.py:
##########
@@ -160,7 +160,7 @@ def test_get_filters_adhoc_filters() -> None:
):
cache = ExtraCache()
assert cache.get_filters("name") == [
- {"op": "IN", "col": "name", "val": ["foo"]}
+ {"op": "IN", "col": "name", "val": ["foo"]},
Review Comment:
ruff-format did this automatically, maybe tests are normally not taken into
account for pre-commit hooks and that's why it was missing before?
##########
tests/unit_tests/jinja_context_test.py:
##########
@@ -160,7 +160,7 @@ def test_get_filters_adhoc_filters() -> None:
):
cache = ExtraCache()
assert cache.get_filters("name") == [
- {"op": "IN", "col": "name", "val": ["foo"]}
+ {"op": "IN", "col": "name", "val": ["foo"]},
Review Comment:
ruff-format did this automatically, maybe tests are normally not taken into
account for pre-commit hooks and that's why it was missing before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
