anantaoutlook commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2071502266
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -58,6 +101,58 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'show_total',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show Total'),
+ default: true,
+ renderTrigger: true,
+ description: t('Show the total value in the waterfall chart'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'bold_total',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Bold Total'),
+ default: true,
+ renderTrigger: true,
+ description: t(
+ 'Bold the total axis label in the waterfall chart',
+ ),
+ },
+ },
+ ],
+ [
+ {
+ name: 'useFirstValueAsSubtotal',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Use first value as subtotal'),
+ default: false,
+ renderTrigger: true,
+ description: t('Render the first bar in the chart as a
subtotal'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'bold_sub_total',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Bold first value as subtotal'),
Review Comment:
removed this control and added a new select control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
