anantaoutlook commented on code in PR #33146: URL: https://github.com/apache/superset/pull/33146#discussion_r2071925800
########## superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx: ########## @@ -58,6 +101,58 @@ const config: ControlPanelConfig = { }, }, ], + [ + { + name: 'show_total', + config: { + type: 'CheckboxControl', + label: t('Show Total'), + default: true, + renderTrigger: true, + description: t('Show the total value in the waterfall chart'), + }, + }, + ], + [ + { + name: 'bold_total', + config: { + type: 'CheckboxControl', + label: t('Bold Total'), Review Comment: removed this control and added a new select control ![Uploading image (38).png…]() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org