mistercrunch commented on code in PR #33360:
URL: https://github.com/apache/superset/pull/33360#discussion_r2074165750
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -245,6 +246,17 @@ export async function embedDashboard({
ourPort.start();
ourPort.defineMethod('observeDataMask', callbackFn);
};
+ const setThemeConfig = async (themeConfig: Record<string, any>):
Promise<void> => {
+ try {
+ ourPort.emit('setThemeConfig', { themeConfig });
Review Comment:
Oh! Can we import the proper type (AnyThemeConfig) from `superset-ui/core`
here? --- now wondering if we should rename it `SupersetThemeConfig`. To
clarify I believe there's the native AntD one (ThemeConfig) the serializable
one (`SerializableThemeConfig`) and AnyThemeConfig joins the two... The main
difference is passing algorithm references as `string` instead of actual AntD
Algorithm objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
