mistercrunch commented on code in PR #33360:
URL: https://github.com/apache/superset/pull/33360#discussion_r2080164362
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -245,6 +246,17 @@ export async function embedDashboard({
ourPort.start();
ourPort.defineMethod('observeDataMask', callbackFn);
};
+ const setThemeConfig = async (themeConfig: Record<string, any>):
Promise<void> => {
+ try {
+ ourPort.emit('setThemeConfig', { themeConfig });
Review Comment:
Spoked internally and since this depends on `template_less`, we can add
proper theme typing support once that ships. In the meantime it's ok to use
generic type. You can add line with something like
```
TODO: add proper theme types once the Theming branch is merged
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
