Vitor-Avila commented on code in PR #33384:
URL: https://github.com/apache/superset/pull/33384#discussion_r2078805830
##########
superset/commands/dataset/update.py:
##########
@@ -86,38 +90,12 @@ def validate(self) -> None:
if not self._model:
raise DatasetNotFoundError()
- # Check ownership
+ # Check permission to update the dataset
try:
security_manager.raise_for_ownership(self._model)
except SupersetSecurityException as ex:
raise DatasetForbiddenError() from ex
- database_id = self._properties.get("database")
-
- catalog = self._properties.get("catalog")
- if not catalog:
- catalog = self._properties["catalog"] = (
- self._model.database.get_default_catalog()
- )
-
- table = Table(
- self._properties.get("table_name"), # type: ignore
- self._properties.get("schema"),
- catalog,
- )
-
- # Validate uniqueness
- if not DatasetDAO.validate_update_uniqueness(
- self._model.database,
- table,
- self._model_id,
- ):
- exceptions.append(DatasetExistsValidationError(table))
-
- # Validate/Populate database not allowed to change
- if database_id and database_id != self._model:
- exceptions.append(DatabaseChangeValidationError())
Review Comment:
Not entirely sure why we didn't want to allow a DB re-map here. This
validation was not really working tho since `database_id` here would never get
a value (as it was reading from `database` as opposed to `database_id`).
That said, I know there are valid use-cases to re-map datasets to other
connections and since it's currently possible, I've removed this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
