Vitor-Avila commented on code in PR #33384:
URL: https://github.com/apache/superset/pull/33384#discussion_r2078816489
##########
superset/commands/dataset/update.py:
##########
@@ -128,15 +106,68 @@
except ValidationError as ex:
exceptions.append(ex)
+ self._validate_dataset_source(exceptions)
self._validate_semantics(exceptions)
if exceptions:
raise DatasetInvalidError(exceptions=exceptions)
- def _validate_semantics(self, exceptions: list[ValidationError]) -> None:
+ def _validate_dataset_source(self, exceptions: list[ValidationError]) ->
None:
# we know we have a valid model
self._model = cast(SqlaTable, self._model)
Review Comment:
I'd say that `validate_dataset_source` makes sense, as these configs appear
in the **Source** tab of the dataset editor. But I'll keep this open to hear
from others too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
