betodealmeida commented on code in PR #33357:
URL: https://github.com/apache/superset/pull/33357#discussion_r2079833512
##########
superset/utils/core.py:
##########
@@ -1741,24 +1741,29 @@ def parse_boolean_string(bool_str: str | None) -> bool:
def apply_max_row_limit(
limit: int,
- max_limit: int | None = None,
+ server_pagination: bool = False,
) -> int:
"""
- Override row limit if max global limit is defined
+ Override row limit based on server pagination setting
:param limit: requested row limit
- :param max_limit: Maximum allowed row limit
+ :param server_pagination: whether server-side pagination is enabled
:return: Capped row limit
- >>> apply_max_row_limit(100000, 10)
- 10
- >>> apply_max_row_limit(10, 100000)
- 10
- >>> apply_max_row_limit(0, 10000)
- 10000
- """
- if max_limit is None:
Review Comment:
Nice, if it's not being used let's get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
