betodealmeida commented on code in PR #33357: URL: https://github.com/apache/superset/pull/33357#discussion_r2079928086
########## superset/common/query_object_factory.py: ########## @@ -96,14 +102,27 @@ def _process_extras( return extras def _process_row_limit( - self, row_limit: int | None, result_type: ChartDataResultType + self, + row_limit: int | None, + result_type: ChartDataResultType, + server_pagination: bool | None = None, Review Comment: ❤️ ########## superset/config.py: ########## @@ -969,6 +969,10 @@ class D3TimeFormat(TypedDict, total=False): # Maximum number of rows returned for any analytical database query SQL_MAX_ROW = 100000 +# Maximum number of rows for any query without Server Pagination in Table Viz type Review Comment: ```suggestion # Maximum number of rows for any query with Server Pagination in Table Viz type ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org