anantaoutlook commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2093497413
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -58,6 +100,50 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'show_total',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Show total'),
+ default: true,
+ renderTrigger: true,
+ description: t('Show the total value in the waterfall chart'),
+ },
+ },
+ ],
+ [
+ {
+ name: 'useFirstValueAsSubtotal',
+ config: {
+ type: 'CheckboxControl',
+ label: t('Use first value as subtotal'),
+ default: false,
+ renderTrigger: true,
+ description: t('Render the first bar in the chart as a
subtotal'),
+ },
+ },
+ ],
+ [
+ {
Review Comment:
fixed
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/controlPanel.tsx:
##########
@@ -133,14 +219,61 @@ const config: ControlPanelConfig = {
description: t('The way the ticks are laid out on the X-axis'),
},
},
+ {
+ name: 'x_ticks_wrap_length',
+ config: {
+ type: 'TextControl',
+ label: t('X tick wrap length'),
+ description: t(
+ 'Maximum line length for wrapped text (when Flat layout is
selected)',
+ ),
+ default: '20',
+ renderTrigger: true,
+ visibility: ({ controls }) =>
+ controls.x_ticks_layout.value === 'flat',
+ },
+ },
+ ],
+ [
+ {
+ name: 'sort_x_axis',
+ config: {
+ type: 'SelectControl',
+ label: t('Sort x axis'),
+ default: 'none',
+ choices: [
+ ['none', t('None')],
+ ['asc', t('Ascending')],
+ ['desc', t('Descending')],
+ ],
+ renderTrigger: true,
+ description: t('Sort X axis in ascending or descending order'),
+ },
+ },
+ ],
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
