michael-s-molina commented on code in PR #33146:
URL: https://github.com/apache/superset/pull/33146#discussion_r2114291092
##########
superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/buildQuery.ts:
##########
@@ -28,6 +28,25 @@ export default function buildQuery(formData: QueryFormData) {
...ensureIsArray(x_axis || granularity_sqla),
...ensureIsArray(groupby),
];
+
+ if (columns.indexOf(formData.seriesOrderByColumn) === -1) {
Review Comment:
Your use case is valid @rea725, thanks for sharing. We have a similar
feature in the Bar chart where users can sort the x-axis by a specific column.
This is different than affecting the GROUP BY clause which is used in the
Waterfall for the breakdowns. In the example below, you can think of Dimensions
as the breakdowns, and users have the ability to sort the x-axis
(`product_line`) by `year`. Notice how the GROUP BY is not affected.
https://github.com/user-attachments/assets/15cd09da-8228-4f48-84ed-7257acd92011
I think we need to change this PR to match the X-Axis Sort By control of the
Bar chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
