castodius opened a new pull request, #33547: URL: https://github.com/apache/superset/pull/33547
### SUMMARY When editing Template Parameters in the frontend the template_parameters key on a dataset gets set to empty string when saving empty data. This breaks export->import since the import validation expects a python dict or nothing. This PR only updates the frontend to not send empty strings to the backend. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF When attempting to upload a Dashboard with a dataset which has had its template parameters removed before exporting.  Network tab for the PUT operation.  Network tab for the PUT operation with the change.  ### TESTING INSTRUCTIONS 1. Edit a dataset belonging to a Dashboard 2. Add template parameters 3. Remove them 4. Export the Dashboard 5. Import the Dashboard Before the fix this should fail, with the fix this should work. ### ADDITIONAL INFORMATION I wanted a proper fix in the backend, but the data gets read/written directly from the database from what I can tell. This is a dirty quick fix that should help some people. <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Maybe https://github.com/apache/superset/issues/27027 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
