alexandrusoare commented on PR #33255: URL: https://github.com/apache/superset/pull/33255#issuecomment-2900450574
Great work @msyavuz ! The page is looking good, I just have a few nits here and there. - When you hover over the login and register buttons there's a slight difference, the register text gets underlined, maybe we can get rid of that: <img width="218" alt="image" src="https://github.com/user-attachments/assets/924bdb26-d080-4697-aacd-aebb3a0f7292"; /> <img width="217" alt="image" src="https://github.com/user-attachments/assets/f5261e19-a820-4211-a715-d8e265ba47ac"; /> - I think we should either reduce a bit the height of the login card or to give a little bit more padding/margin to buttons on the top so that we can have some better proportions, let me know what you think: <img width="587" alt="image" src="https://github.com/user-attachments/assets/4dedf824-121e-41cc-b873-82d4c2b6aca4"; /> - Maybe center the inputs and labels or at least place them on the left <img width="907" alt="image" src="https://github.com/user-attachments/assets/59872cb8-686a-4d7b-bc5c-9703f0a537f8"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
