msyavuz commented on code in PR #33255:
URL: https://github.com/apache/superset/pull/33255#discussion_r2113585167
##########
superset/views/utils.py:
##########
@@ -71,8 +71,8 @@ def sanitize_datasource_data(datasource_data: dict[str, Any])
-> dict[str, Any]:
def bootstrap_user_data(user: User, include_perms: bool = False) -> dict[str,
Any]:
if user.is_anonymous:
payload = {}
- user.roles = (security_manager.find_role("Public"),)
- elif security_manager.is_guest_user(user):
+ user.roles = (current_app.appbuilder.sm.find_role("Public"),)
+ elif current_app.appbuilder.sm.is_guest_user(user):
payload = {
Review Comment:
You are correct, these were measures i took to avoid circular imports but
they are not necessary anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
