kgabryje commented on code in PR #33559:
URL: https://github.com/apache/superset/pull/33559#discussion_r2104241118
##########
superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts:
##########
@@ -111,11 +124,36 @@ export default function transformProps(
const { setDataMask = () => {}, onContextMenu } = hooks;
const colorFn = CategoricalColorNamespace.getScale(colorScheme as string);
const numberFormatter = getNumberFormatter(numberFormat);
+ const denormalizedSeriesValues: SeriesNormalizedMap = {};
+
+ const getDenormalizedSeriesValue = (
+ seriesName: string,
+ normalisedValue: string,
+ ): number => {
+ if (
+ Object.prototype.hasOwnProperty.call(
+ denormalizedSeriesValues,
+ seriesName,
+ ) &&
+ Object.prototype.hasOwnProperty.call(
+ denormalizedSeriesValues[seriesName],
+ normalisedValue,
+ )
Review Comment:
Can't we just do `denormalizedSeriesValues?.[seriesName]?.[normalisedValue]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
