kgabryje commented on code in PR #33559: URL: https://github.com/apache/superset/pull/33559#discussion_r2104244329
########## superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts: ########## @@ -259,6 +330,39 @@ export default function transformProps( }, ]; + const NormalisedTooltipFormater = ( + params: CallbackDataParams & { + color: string; + name: string; + value: number[]; + }, + ) => { + const { color } = params; + const seriesName = params.name || ''; + const values = params.value; + + const colorDot = `<span style="display:inline-block;margin-right:5px;border-radius:50%;width:5px;height:5px;background-color:${color}"></span>`; Review Comment: You could move NormalisedTooltipFormatter to a separate .tsx file and use JSX instead of strings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org