sfirke commented on PR #33716: URL: https://github.com/apache/superset/pull/33716#issuecomment-2966382133
Thank your for the video (and the contribution!), I think this looks great. My only immediate suggestion is that I feel like "Gantt chart" is a more common name for this than "Timeline chart." There are more comments in our repo for "Gantt chart" including this feature request with many upvotes - your feature will make them happy 😁 https://github.com/apache/superset/discussions/23503 so I think that's what our users will search for. And Wikipedia calls it a Gantt chart, it has no entry for timeline chart. What do you think about renaming this chart to be "Gantt chart"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
