mistercrunch commented on code in PR #33716:
URL: https://github.com/apache/superset/pull/33716#discussion_r2150581959
##########
superset-frontend/packages/superset-ui-chart-controls/src/sections/chartTitle.tsx:
##########
@@ -47,21 +76,7 @@ export const titleControls: ControlPanelSectionConfig = {
},
},
],
- [
- {
- name: 'x_axis_title_margin',
- config: {
- type: 'SelectControl',
- freeForm: true,
- clearable: true,
- label: t('X Axis Title Margin'),
- renderTrigger: true,
- default: TITLE_MARGIN_OPTIONS[0],
- choices: formatSelectOptions(TITLE_MARGIN_OPTIONS),
- description: t('Changing this control takes effect instantly'),
- },
- },
- ],
+ [xAxisTitleMarginControl],
Review Comment:
for consistency with other charts, should you just bring the entire
`titleControls` section here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
