Re: [PR] fix: Update dataset changed_on timestamp for all attribute changes [superset]

Fri, 20 Jun 2025 10:26:47 -0700 


korbit-ai[bot] commented on code in PR #33845:
URL: https://github.com/apache/superset/pull/33845#discussion_r2159407877


##########
superset/daos/dataset.py:
##########
@@ -197,7 +197,7 @@ def update(
                 cls.update_metrics(item, attributes.pop("metrics"))
                 force_update = True
 
-            if force_update:
+            if attributes or force_update:
                 attributes["changed_on"] = datetime.now()

Review Comment:
   ### Undocumented changed_on timestamp behavior change <sub>![category 
Documentation](https://img.shields.io/badge/Documentation-7c3aed)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The change in the condition from `if force_update:` to `if attributes or 
force_update:` is not documented. This is a significant behavior change that 
affects when the `changed_on` timestamp is updated.
   
   
   ###### Why this matters
   Future developers may not understand why both empty attributes and 
force_update can trigger a timestamp update, leading to potential confusion 
about the timestamp update behavior.
   
   ###### Suggested change ∙ *Feature Preview*
   Update the method's docstring to explain:
   ```python
       """Updates a Dataset model on the metadata DB
       
       The changed_on timestamp is updated when there are attribute changes
       or when columns/metrics are updated (force_update).
       """
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6eefdf29-a9ab-4a38-93dd-90b0ddebecca/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6eefdf29-a9ab-4a38-93dd-90b0ddebecca?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6eefdf29-a9ab-4a38-93dd-90b0ddebecca?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6eefdf29-a9ab-4a38-93dd-90b0ddebecca?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/6eefdf29-a9ab-4a38-93dd-90b0ddebecca)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:13313d04-c090-4fae-adf0-c2eadd5fc0b7 -->
   
   
   [](13313d04-c090-4fae-adf0-c2eadd5fc0b7)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to