Vitor-Avila commented on PR #33845: URL: https://github.com/apache/superset/pull/33845#issuecomment-3001905477
@abhinav-1305 are you sure this is still needed on `master`? I believe this was already fixed with my previous PR: https://github.com/apache/superset/pull/33626 I just recorded this video from `master`: https://github.com/user-attachments/assets/e69960c1-fb06-4ded-b4d1-9f90c38ac3ba The reason we just manually update the `changed_on` value if `force_update` is `True`, is because in case there's dataset modifications, an `UPDATE` SQL statement will be executed against the DB table automatically updating the `changed_on` attribute, so that should not be needed. We need to do it when updating only metrics or columns because these updates affect other DB tables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
