nathanjrobertson commented on code in PR #33889:
URL: https://github.com/apache/superset/pull/33889#discussion_r2193883811
##########
helm/superset/Chart.yaml:
##########
@@ -29,7 +29,7 @@ maintainers:
- name: craig-rueda
email: cr...@craigrueda.com
url: https://github.com/craig-rueda
-version: 0.14.2
Review Comment:
I think it would be good to add a comment here stating the convention of the
chart version. For example:
```
# The version of this chart (not Superset itself - that's appVersion). The
convention for the chart version X.Y.Z is:
# X: Remains "0"
# Y: Is incremented if appVersion has a major or minor upgrade in version
(eg. 4.0 to 4.1, or 4.1 to 5.0), or there is a breaking change in the chart
itself.
# Z: "0" if Y is incremented, otherwise incremented for any non-breaking
change to the chart or a patch release of the appVersion (eg. 4.1.0 to 4.1.1).
```
If somebody disagrees with my definition and wants something else, that's
fine. But having an explicit definition is what we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
