Re: [PR] feat: add bulk certify functionality to charts and dashboards [superset]

[via GitHub]

vedantprajapati commented on PR #33002:
URL: https://github.com/apache/superset/pull/33002#issuecomment-3053489308

   > > are we good to merge this one for now then?
   > > > Though from my perspective the current UX (as of this PR) is "ok for 
now".
   > 
   > thanks @vedantprajapati and sorry for the long wait!
   > 
   > I think the perfect case scenario would be to combine all actions in a 
dropdown as we actually have 4 actions @mistercrunch:
   > 
   > * delete
   > * certify
   > * export
   > * tag (which is not really visible)
   > 
   > I would suggest using 
[this](https://ant.design/~demos/dropdown-demo-loading) component, the one with 
the caret down <img alt="image" width="91" 
src="https://private-user-images.githubusercontent.com/36897697/451947992-e3e28a0a-a302-4c13-8a26-645153984b0c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTIwODEwODUsIm5iZiI6MTc1MjA4MDc4NSwicGF0aCI6Ii8zNjg5NzY5Ny80NTE5NDc5OTItZTNlMjhhMGEtYTMwMi00YzEzLThhMjYtNjQ1MTUzOTg0YjBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNzA5VDE3MDYyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZiNjZiOTM1YTgxYTgyNjhmYzVmYTcwYzE1ZDUyMDhjOTFkOGM0ZDQ2YzBmOWJhNTk4ZjgxNGU5YzNkYWVmODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.P1RKbbupsuz-aMpfSXe9bvTOMYbKbaUGJDPpq1hnBZ4";>
   > 
   > Primary action would be export and all of the other ones would be in the 
dropdown menu (certify, tag, delete) and it would be displayed next to 
"deselect all" instead of all of the buttons.
   > 
   > Thoughts?
   
   Hey @kasiazjc @mistercrunch ,
   I've added the component in superset now! let me know if this works for you 
and I can proceed with making the test fixes.
   
   <img width="711" alt="image" 
src="https://github.com/user-attachments/assets/b8511c6e-250a-4897-9100-00d121c47903";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org