mistercrunch commented on a change in pull request #7641: [SQL Lab] Clarify SQL
Lab query and display limits
URL:
https://github.com/apache/incubator-superset/pull/7641#discussion_r290129327
##########
File path: superset/views/utils.py
##########
@@ -184,3 +184,10 @@ def get_datasource_info(datasource_id, datasource_type,
form_data):
'The datasource associated with this chart no longer exists')
datasource_id = int(datasource_id)
return datasource_id, datasource_type
+
+def apply_display_max_row_limit(data):
Review comment:
Maybe add a docstring explaining why it's mutating this `sql_results`
payload, something like:
```
"""
Given a `sql_results` nested structure, applies a limit to the number of rows
`sql_results` here is the nested structure coming out of
sql_lab.get_sql_results, it contains
metadata about the query, as well as the data set returned by the query.
This method
limits the number of rows adds a `displayLimitReached: True` flag to the
metadata
"""
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
