mistercrunch commented on a change in pull request #7641: [SQL Lab] Clarify SQL
Lab query and display limits
URL:
https://github.com/apache/incubator-superset/pull/7641#discussion_r291462834
##########
File path: superset/views/core.py
##########
@@ -2710,8 +2710,10 @@ def sql_json(self):
rendered_query,
return_results=True,
user_name=g.user.username if g.user else None)
+
+
payload = json.dumps(
- data,
+ apply_display_max_row_limit(data),
Review comment:
CSV button is only shown after the query was executed, and if it did run
async (has a results_key), it will download it from results cache.
https://github.com/apache/incubator-superset/blob/5470d10155e28c96b54615a36464c6c4afc0a38b/superset/views/core.py#L2754
If not async, it reruns the query, but takes a total shortcut which seems
like it could be wrong to me in some cases, but not related to this PR...
https://github.com/apache/incubator-superset/blob/5470d10155e28c96b54615a36464c6c4afc0a38b/superset/views/core.py#L2770
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
