gabotorresruiz opened a new pull request, #34144: URL: https://github.com/apache/superset/pull/34144
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This change adds full support for Superset’s bootstrap-provided theme objects (default, dark, and settings) and integrates them into the existing ThemeController API. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Pass a valid `Theme` dict to `THEME_DEFAULT` and or `THEME_DARK` (you can generate one in the Ant Design theme editor: https://ant.design/theme-editor) 2. Reload the frontend app 3. Watch the magic happens For `THEME_SETTINGS`: 1. Pass a valid `ThemeSettings` dict E.g.: ``` THEME_SETTINGS = { "enforced": True, # If True, forces the default theme and ignores user preferences "allowSwitching": True, # Allow user to switch between themes (default and dark) "allowOSPreference": True, # Allow the app to Auto-detect and set system theme preference } ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
