mistercrunch commented on code in PR #34144:
URL: https://github.com/apache/superset/pull/34144#discussion_r2202066882
##########
superset-frontend/packages/superset-ui-core/src/theme/types.ts:
##########
@@ -33,18 +33,33 @@ import { Theme } from '.';
export type AntdTokens = ReturnType<typeof antdThemeImport.getDesignToken>;
export type AntdThemeConfig = ThemeConfig;
+/**
+ * A combination of theme modes that can be used in theme config.
+ * This is used to define which algorithms are allow to be applied together.
+ */
+export type ThemeAlgorithmCombination = (
Review Comment:
I think there's a drier way to write all this, maybe something like:
```ts
export enum ThemeMode {
DEFAULT = 'default',
DARK = 'dark',
COMPACT = 'compact',
}
export type ThemeAlgorithmCombination = ThemeMode[];
export type ThemeAlgorithmOption = ThemeMode | ThemeAlgorithmCombination;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
