rusackas opened a new pull request, #34662: URL: https://github.com/apache/superset/pull/34662
## Summary This PR fixes dataset creation for Impala databases by adding Impala dialect support to the sqlglot SQL parser. ## Motivation - Fixes #32143 - Users with Impala databases were unable to create datasets after upgrading to Superset 4.1.1 - The issue was caused by sqlglot not recognizing the Impala SQL dialect, leading to parse errors ## Solution Since Impala's SQL syntax is very similar to Hive, this PR maps the Impala engine to use the Hive dialect in sqlglot. This is consistent with how the Ascend engine (which is also Impala-based) is already configured. ## Testing - Added comprehensive unit tests for Impala SQL parsing - Tests verify that common Impala SQL constructs (SELECT, JOIN, INSERT, CREATE TABLE) are properly parsed - All existing tests continue to pass ## Checklist - [x] Has associated issue: #32143 - [x] Required feature flags: None - [x] API changes: None - [x] Original bug cause identified: Missing Impala dialect mapping in SQLGLOT_DIALECTS - [x] Unit tests added - [x] Pre-commit checks pass 🤖 Generated with [Claude Code](https://claude.ai/code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
