Re: [PR] fix(sql): Add Impala dialect support to sqlglot parser [superset]

Tue, 12 Aug 2025 12:25:33 -0700 


korbit-ai[bot] commented on code in PR #34662:
URL: https://github.com/apache/superset/pull/34662#discussion_r2270953564


##########
superset/sql/parse.py:
##########
@@ -81,7 +81,7 @@
     "hana": Dialects.POSTGRES,
     "hive": Dialects.HIVE,
     # "ibmi": ???
-    # "impala": ???
+    "impala": Dialects.HIVE,

Review Comment:
   ### Incomplete Impala SQL Support <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Direct mapping of Impala to Hive dialect may not handle Impala-specific SQL 
syntax variations correctly.
   
   
   ###### Why this matters
   While Impala is similar to Hive, it has some syntax variations and features 
that differ from Hive. Using Hive's dialect directly could lead to incorrect 
parsing or errors when processing Impala-specific SQL constructs.
   
   ###### Suggested change ∙ *Feature Preview*
   Consider creating a custom Impala dialect that extends the Hive dialect to 
handle Impala-specific syntax variations:
   ```python
   class ImpalaDialect(Dialects.HIVE):
       # Override or add methods to handle Impala-specific syntax
       pass
   
   # Then update the mapping
   "impala": ImpalaDialect,
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/52c2a272-5c3e-4998-9017-3e3e0bfeb806/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/52c2a272-5c3e-4998-9017-3e3e0bfeb806?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/52c2a272-5c3e-4998-9017-3e3e0bfeb806?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/52c2a272-5c3e-4998-9017-3e3e0bfeb806?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/52c2a272-5c3e-4998-9017-3e3e0bfeb806)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:ff31ae9c-b59a-4296-880a-23d501307304 -->
   
   
   [](ff31ae9c-b59a-4296-880a-23d501307304)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to