amaannawab923 commented on issue #33448: URL: https://github.com/apache/superset/issues/33448#issuecomment-3222611299
Even i had the same feeling @yousoph , i can make it backwards compatible and allow users to edit charts within embedded explore but the problem is , users are used to click "Edit Chart" which leads to explore page , how should i handle it for existing charts... Should i keep 2 options ? Edit within Dashboard , Edit in Explore/Chart Edit ? How do i handle that, if we can handle that case we can handle backwards compatibility A new Dashboard item was needed because what if someone just needs to create a chart from scratch , they will need to paste a chart into dashboard and then edit it, Felt more like a hack for creating a new chart within dashboard hence i ended up creating a new dashboard item for the need to create a Chart from scratch within dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
