mistercrunch commented on issue #33448:
URL: https://github.com/apache/superset/issues/33448#issuecomment-3222308591
This looks great, and didn't look in the code deep, but still thinking the
best approach to hit those goals are:
- pass props to modify/simplify how Explore itself renders (`hidePanels={}`
or `mode="slim"` or `hideMetadataPanel={true}`). Gotta do more thinking on what
all the options might be
- I'd avoid "re-composing" existing objects in different ways
For the goal of embedding explore on top of a dashboard
- strip down / remove completely the redux usage in Explore, make it more of
a proper component managing its own state
- OR move towards a single-store architecture with the proper action/reducer
composition (seems challenging)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
