adolfotcar commented on PR #34880: URL: https://github.com/apache/superset/pull/34880#issuecomment-3234288654
@sadpandajoe I think that not reverting leads to more issues. Imagine you have a dashboard that has chart's column as a filter and you export it. Over the next few days you remove that column from the dataset and chart and also remove the filter from the dashboard but then you want to revert your job back to the way it was before the changes, it will import the dashboard back again with that column as filter but now the chart and datasets won't have that column anymore. When you have multiple environments as well it makes much easier for the development to have everything being overwritten: you do all the changes in dashboards, charts and dataset in a test environment and when moving to production you export only the dashboard and import it rather than having to keep track of all your changes and export one by one. In the end, the user is asked whether they want to overwrite and their answer is what defines if the assets will be overwritten or not. Maybe there should be more explicit message about what happens when overwriting? Another solution I guess would be to have an option to "overwrite only dashboard" or "overwrite all assets". A simpler solution to this would be to have an option in the config.py file this way the UI won't require any changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
