rusackas commented on PR #34880:
URL: https://github.com/apache/superset/pull/34880#issuecomment-3234292623

   Looks like there's also this to contend with:
   
   ```
   tests/unit_tests/commands/dashboard/importers/v1/assets_test.py:101:89: E501 
Line too long (95 > 88)
       |
    99 |     imported_dataset = 
db.session.query(SqlaTable).filter_by(uuid=dataset_uuid).one()
   100 |
   101 |     # extracting changed_on field to compare with the previous 
retrieved, ignoring milliseconds
       |                                                                        
                 ^^^^^^^ E501
   102 |     final_dashboard_changed_on = 
imported_dashboard.changed_on.strftime(
   103 |         "%Y-%m-%d %H:%M:%S"
       |
   ```
   
   Superset uses Git pre-commit hooks courtesy of 
[pre-commit](https://pre-commit.com/). To install run the following:
   ```
   pip3 install -r requirements/development.txt
   pre-commit install
   ```
   A series of checks will now run when you make a git commit.
   
   Alternatively it is possible to run pre-commit by running pre-commit 
manually:
   ```
   pre-commit run --all-files
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to