[GitHub] [incubator-superset] etr2460 opened a new pull request #7701: Update @superset-ui/legacy-preset-chart-nvd3

[GitBox]

etr2460 opened a new pull request #7701: Update 
@superset-ui/legacy-preset-chart-nvd3
URL: https://github.com/apache/incubator-superset/pull/7701
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Pulls in fix for stacked bar charts from the superset-ui library. Before, 
stacked bar chart value labels would not update when series were 
disabled/enabled
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   Before:
   <img width="1250" alt="Screen Shot 2019-06-12 at 5 59 08 PM" 
src="https://user-images.githubusercontent.com/7409244/59396110-08ff1600-8d3c-11e9-8bd6-6e243fd6296d.png";>
   <img width="1242" alt="Screen Shot 2019-06-12 at 5 59 18 PM" 
src="https://user-images.githubusercontent.com/7409244/59396111-08ff1600-8d3c-11e9-8662-294fb5ebc502.png";>
   
   After:
   <img width="1241" alt="Screen Shot 2019-06-12 at 5 50 48 PM" 
src="https://user-images.githubusercontent.com/7409244/59396115-0d2b3380-8d3c-11e9-937c-9f456462bf9f.png";>
   <img width="1250" alt="Screen Shot 2019-06-12 at 5 50 59 PM" 
src="https://user-images.githubusercontent.com/7409244/59396116-0d2b3380-8d3c-11e9-8383-7655bb9f4dfc.png";>
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   See the results above in the screenshots when using a stacked bar chart
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @graceguo-supercat, @kristw, @michellethomas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org