msyavuz opened a new pull request, #35303:
URL: https://github.com/apache/superset/pull/35303

   ### SUMMARY
   This PR fixes an issue where the "Clear All" button in the filter bar 
doesn't properly clear dependent filters when they have required parent filters.
   
   The main changes:
   1. **FilterBar**: Changed to iterate over all native filters instead of just 
those in scope, ensuring dependent filters are cleared even if their parent was 
cleared first
   2. **SelectFilterPlugin**: Added logic to skip applying default values when 
the clearAllTrigger is active, preventing filters from immediately reverting to 
their default values during a Clear All operation
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before**: When clicking "Clear All", dependent filters with required 
parents would not be cleared properly, remaining in their previous state or 
reverting to default values.
   
   **After**: All filters, including dependent ones, are properly cleared when 
clicking "Clear All".
   
   ### TESTING INSTRUCTIONS
   1. Create a dashboard with native filters that have parent-child dependencies
   2. Set up a child filter that requires a parent filter selection
   3. Configure the child filter with "Default to first item" enabled
   4. Select values in both parent and child filters
   5. Click the "Clear All" button
   6. Verify that both parent and child filters are cleared and don't revert to 
default values
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to