geido commented on code in PR #35303:
URL: https://github.com/apache/superset/pull/35303#discussion_r2387532086
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -349,17 +349,21 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
}
// Handle the default to first Value case
- if (defaultToFirstItem) {
- // Set to first item if defaultToFirstItem is true
- const firstItem: SelectValue = data[0]
- ? (groupby.map(col => data[0][col]) as string[])
- : null;
- if (firstItem?.[0] !== undefined) {
- updateDataMask(firstItem);
+ // Skip default values when clearAllTrigger is active to prevent
+ // defaults from being applied during Clear All operation
+ if (!clearAllTrigger) {
Review Comment:
It would be useful to add/enhance tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
