janani-gurram commented on issue #33738:
URL: https://github.com/apache/superset/issues/33738#issuecomment-3386641656

   We’re proposing the following fix to address this issue:
   - before calling to_numeric, we first apply dropna() on the input DataFrame
   - if the DataFrame is empty after dropping nulls, we return the empty 
DataFrame
   - otherwise, we continue as usual
   
   We also plan to add test cases to validate this behavior when the target 
column has all nulls (with and without grouping) and when the target column has 
some nulls (with and without grouping).
   
   We’d appreciate any community feedback on this approach


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to