eschutho commented on code in PR #35591:
URL: https://github.com/apache/superset/pull/35591#discussion_r2427102917
##########
superset/commands/report/execute.py:
##########
@@ -449,7 +460,18 @@ def _get_embedded_data(self) -> pd.DataFrame:
logger.info("Getting chart from %s as user %s", url, user.username)
dataframe = get_chart_dataframe(url, auth_cookies)
except SoftTimeLimitExceeded as ex:
- raise ReportScheduleDataFrameTimeout() from ex
+ chart_id = self._report_schedule.chart_id
+ chart_name = self._report_schedule.chart.slice_name
+ timeout = self._report_schedule.working_timeout or app.config.get(
+ "ALERT_REPORTS_DEFAULT_WORKING_TIMEOUT", 3600
+ )
+ error_msg = (
+ f"Timeout fetching data for chart '{chart_name}' "
+ f"(ID: {chart_id}). The chart query exceeded the {timeout} "
+ f"second timeout limit. Consider optimizing the chart query "
Review Comment:
I’m pretty sure at least that they don’t bubble up but either way, we’ll
want to log for just one audience instead of both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
