kgabryje opened a new pull request, #35416:
URL: https://github.com/apache/superset/pull/35416

   ### SUMMARY
   This PR fixes some UI 6.0 bugs.
   1. Due to a bug in our AntD version, the splitter (component for changing 
containers heights) in SQL Lab would sometimes freeze the UI and nothing could 
be done until user refreshes the page. This was fixed by bumping AntD version
   2. The confirmation modal when swapping datasources in Explore had 2 primary 
buttons - there should only be 1
   3. The alert after swapping datasets in Explore - the buttons for clearing 
the control panel or dismissing the alert were missing
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://github.com/user-attachments/assets/818a0b89-0a2e-40bd-af64-5dc7cec4e6c9
   
   
   <img width="443" height="233" alt="image" 
src="https://github.com/user-attachments/assets/4cbc01e5-02f7-4e02-a6d0-4f94a2ca2205";
 />
   
   <img width="350" height="194" alt="image" 
src="https://github.com/user-attachments/assets/1ae61d4d-8359-4f5a-8786-91070049b6b6";
 />
   
   After:
   
   
https://github.com/user-attachments/assets/55c90524-d38e-4a68-9aa8-0cd1eb7688ce
   
   <img width="459" height="236" alt="image" 
src="https://github.com/user-attachments/assets/2c9ef7ca-0302-4463-9e45-26de5b428e05";
 />
   
   <img width="349" height="237" alt="image" 
src="https://github.com/user-attachments/assets/f3828a00-db12-4923-81f1-331f339237f8";
 />
   
   
   ### TESTING INSTRUCTIONS
   1. Go to SQL Lab, play with the splitter a bit, confirm that it doesnt freeze
   2. Go to Explore, swap the dataset
   3. Verify that the confirmation modal has a primary button for confirm and 
secondary for cancel
   4. Verify that the alert in the control panel has visible buttons for 
dismising the alert and clearing the control panel
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to