mistercrunch commented on code in PR #35237:
URL: https://github.com/apache/superset/pull/35237#discussion_r2374654659
##########
superset/views/core.py:
##########
@@ -440,18 +438,8 @@ def explore( # noqa: C901
dataset_id = request.args.get("dataset_id")
if slice_id:
initial_form_data["slice_id"] = slice_id
- if form_data_key:
- flash(
- _("Form data not found in cache, reverting to chart
metadata.")
Review Comment:
part of a function flagged as @deprecated
##########
superset/views/core.py:
##########
@@ -440,18 +438,8 @@ def explore( # noqa: C901
dataset_id = request.args.get("dataset_id")
if slice_id:
initial_form_data["slice_id"] = slice_id
- if form_data_key:
- flash(
- _("Form data not found in cache, reverting to chart
metadata.")
- )
elif dataset_id:
initial_form_data["datasource"] = f"{dataset_id}__table"
- if form_data_key:
- flash(
- _(
- "Form data not found in cache, reverting to
dataset metadata." # noqa: E501
Review Comment:
part of a function flagged as @deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
