mistercrunch commented on code in PR #35237:
URL: https://github.com/apache/superset/pull/35237#discussion_r2374670609
##########
superset/views/core.py:
##########
@@ -652,13 +636,6 @@ def save_or_overwrite_slice( # noqa: C901
_("You don't have the rights to alter this dashboard"),
status=403,
)
-
- flash(
- _("Chart [{}] was added to dashboard [{}]").format(
Review Comment:
tested that chart adding to dashboard is handled frontend now and flashed
properly without these obsolete flash messages
##########
superset/views/core.py:
##########
@@ -673,12 +650,6 @@ def save_or_overwrite_slice( # noqa: C901
dashboard_title=request.args.get("new_dashboard_name"),
owners=[g.user] if g.user else [],
)
- flash(
- _(
- "Dashboard [{}] just got created and chart [{}] was added
to it"
Review Comment:
tested that chart adding to dashboard is handled frontend now and flashed
properly without these obsolete flash messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
